Conversation
tushar00jain
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
facebook-github-bot
added
the
CLA Signed
wconstab
left a comment
wconstab
left a comment
There was a problem hiding this comment.
this PR has a vague description but changes a lot of code. It is clearly more than removing dead code. The changes to pipeline split points look like they need a careful review and i'd be curious first to understand the motivation for the changes. I'd also suggest breaking the change into smaller PRs if possible for easier reviews.
|
@wconstab these are 3 different commits and 3 different pr's created by sapling :) the first pr isn't owned by me (i'm building on top of it but had to push it so i can start creating other pr's in parallel) this pr is a one line change, to review contents of each pr, you can go to the last commit in the commits section. the commit name is the same as the pr name 
|
|
Got it. Sorry! |
tushar00jain
force-pushed
the
pr1450
branch
2 times, most recently
from
a86dfa2 to
9249ac7
Compare
tushar00jain
force-pushed
the
pr1450
branch
4 times, most recently
from
f3647ec to
649490e
Compare
Summary: remove some stale code that determines parameters to pass to outer optimizer
6 participants
Summary:
remove some stale code that determines parameters to pass to outer optimizer
Stack created with Sapling. Best reviewed with ReviewStack.